ui: introduce new "embedder" interface to place deployment vars#4822
Open
LalitMaganti wants to merge 2 commits intomainfrom
Open
ui: introduce new "embedder" interface to place deployment vars#4822LalitMaganti wants to merge 2 commits intomainfrom
LalitMaganti wants to merge 2 commits intomainfrom
Conversation
This CL introduces a new "embedder" interface to allow for people deploying their own instances of the Perfetto UI to be able to easily configure a bunch of changes without needing to make changes to the source code smeared across the codebase. This interface will eventually host all the deployment specific things but for now I've just moved one thign over which is the GA id. Followup changes will move the "default extension server" here also.
Member
Author
|
@primiano FYI |
🎨 Perfetto UI Builds |
LalitMaganti
commented
Feb 17, 2026
| * the UI to adapt to the environment it's running in (e.g. ui.perfetto.dev | ||
| * vs a third-party embedding). | ||
| */ | ||
| export interface Embedder { |
Member
Author
There was a problem hiding this comment.
Do we like Embedder as a name or do we prefer "deployment" or something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL introduces a new "embedder" interface to allow for people
deploying their own instances of the Perfetto UI to be able to easily
configure a bunch of changes without needing to make changes to the
source code smeared across the codebase.
This interface will eventually host all the deployment specific things
but for now I've just moved one thign over which is the GA id. Followup
changes will move the "default extension server" here also.