trace_processor: Parse adreno_cmdbatch_retired/sync events#5817
Open
rossning92 wants to merge 1 commit into
Open
trace_processor: Parse adreno_cmdbatch_retired/sync events#5817rossning92 wants to merge 1 commit into
rossning92 wants to merge 1 commit into
Conversation
Contributor
|
I'll try this out shortly. Give me a few days though - hopefully this is not in a rush. |
Contributor
Author
|
@batesj no rush many thanks for the help! |
Contributor
|
@rossning92 I'm getting a build error: |
Add custom parsing for kgsl adreno_cmdbatch_sync and adreno_cmdbatch_retired ftrace events to produce GPU timeline slices in the trace processor. The sync event provides a per-cmdbatch reference point (ftrace timestamp paired with GPU ticks) used to convert GPU tick values from the retired event into trace timestamps. This avoids cross-clock-domain issues with the submitted event's secs/usecs (CLOCK_REALTIME) fields.
rossning92
force-pushed
the
tp-adreno-cmdbatch
branch
from
fbe508d to
cae15ed
Compare
Contributor
Author
|
@batesj My bad. I did a rebase on to main branch, but apparently some structure name changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom parsing for kgsl adreno_cmdbatch_sync and adreno_cmdbatch_retired ftrace events to produce GPU timeline slices in the trace processor.
This is a rework of #5519 (reverted in #5793) which fixes the GPU event drift in the timeline by using per-cmdbatch sync points instead of a single global clock snapshot.
TODO: Pending confirmation if this PR fixes all drift issues that @batesj has observed on his end.
Test run result: