Skip to content

ui: Autofocus query page editor on tab creation #5875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevegolton wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

ui: Autofocus query page editor on tab creation #5875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e06e829
ui: Autofocus query page editor on tab creation
stevegolton May 14, 2026
7051267
Fix unrelated screenshot tests
stevegolton May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../omnibox.test.ts/command-palette-keyboard-navigation/command-palette-pos-end-1.png.sha256
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ac7f46b7923ce72d3169d94cc7e65a7ca4c3183ae12935d29ae624f93768b8c7
b42a4fde8d72ad48da91225bb95c9da2165e428b627619cdcd5ddebe7810f846
2 changes: 1 addition & 1 deletion .../omnibox.test.ts/command-palette-keyboard-navigation/command-palette-pos-end-2.png.sha256
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
451ccf06b779ec4abf550f875db0c289c767d3702d92ad2649cb7b3e3e7b6e8c
189566f8a644f33f4341790a42ce4c908f58dbc27f13be691181365a6d142466
1 change: 1 addition & 0 deletions ui/src/plugins/dev.perfetto.QueryPage/query_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ export class QueryPage implements m.ClassComponent<QueryPageAttrs> {
),
),
m(Editor, {
autofocus: true, // Auto focus when we create a new tab for instance.
language: 'perfetto-sql',
text: tab.editorText,
onUpdate: (content) => attrs.onEditorContentUpdate?.(tab.id, content),
Expand Down
Loading