Remove trigger field from StackWalk ETW event#5895
Open
jessemckenna wants to merge 1 commit into
Open
Conversation
🎨 Perfetto UI Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the
triggerfield fromStackWalkEtwEvent. It also updates the event proto's comment to refer to the correctCallstackmessage (just a small cleanup while I'm here).The
triggerfield was intended to contain the type of event that triggered the call stack event, e.g., "CSWITCH", and be populated by the trace recorder. However, the work involved in matching eachStackWalkevent to its corresponding ETW event is better suited to being done in the trace processor, so this proto field is not needed.The field is being removed, rather than deprecated, because it hasn't been used in any Chromium code yet. Since it has no references in any other code, I think it's safe to remove outright.