tp: remove FindById and replace with operator[]#5906
Merged
Conversation
Instead of blindly casting without bounds checking, just verify it's in bounds of the table.
Now that ids are guaranteed to appear in tables, there's no point having std::optional on the API boundary. Just make it always return the RowReference instead.
🎨 Perfetto UI Builds
|
sashwinbalaji
approved these changes
May 15, 2026
LalitMaganti
force-pushed
the
dev/lalitm/remove-findbyid
branch
from
5dcfef4 to
7753d4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that ids are guaranteed to appear in tables, there's no point
having std::optional on the API boundary. Just make it always return
the RowReference instead.