protos: include GPU TrackEvent/InternedData extensions in trace:zero#5913
Open
dreveman wants to merge 1 commit into
Open
protos: include GPU TrackEvent/InternedData extensions in trace:zero#5913dreveman wants to merge 1 commit into
dreveman wants to merge 1 commit into
Conversation
The base GPU protos (gpu_counter_event.proto, gpu_render_stage_event.proto, etc.) are already pulled in via gpu:@type@. The two extension protos (gpu_track_event.proto, gpu_interned_data.proto) live in stand-alone sub-targets so trace_processor can build per-extension descriptors with exclude_imports = true, but they're producer-side protos too — pull them into the main trace group so the SDK amalgamation ships their pbzero / cpp / lite headers alongside the base GPU messages.
Member
|
I'm not sure we want this to be honest. If anything we should be going in the other direction and reducing what we are shipping in the SDK nof adding more targets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base GPU protos (gpu_counter_event.proto, gpu_render_stage_event.proto, etc.) are already pulled in via gpu:@type@. The two extension protos (gpu_track_event.proto, gpu_interned_data.proto) live in stand-alone sub-targets so trace_processor can build per-extension descriptors with exclude_imports = true, but they're producer-side protos too — pull them into the main trace group so the SDK amalgamation ships their pbzero / cpp / lite headers alongside the base GPU messages.