gn: Simplify logic for finding Clang resource directory#5915
Open
pcc wants to merge 1 commit into
Open
Conversation
This code was using a convoluted way of determining the resource directory that doesn't always work (for example, the resource directory is not guaranteed to have a /clang/ component). Replace it with a call to `clang -print-resource-dir`.
Member
|
What version of clang does this work for? Because I'm not certain this was necessarily always supported. |
Contributor
Author
|
It's been supported since Clang 5: llvm/llvm-project@51208a3 |
LalitMaganti
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code was using a convoluted way of determining the resource directory that doesn't always work (for example, the resource directory is not guaranteed to have a /clang/ component). Replace it with a call to
clang -print-resource-dir.