Skip to content

Enhancement/10145-vitest-migration #10858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: enhancement/10091-storybook-dependencies-latest-nodejs
Choose a base branch
from

Conversation

benbowler
Copy link
Collaborator

@benbowler benbowler commented Jun 2, 2025

Summary

Addresses issue:

Relevant technical choices

VITest base infra with 52% of tests fixed and passing.

An early note the current suite is running slower than Jest was. Although this could be todo with the number of failing tests still. In another hackathon I can get this ready for review.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

google-cla bot commented Jun 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@benbowler benbowler changed the base branch from develop to enhancement/10091-storybook-dependencies-latest-nodejs June 2, 2025 07:44
Comment on lines +6 to +9
plugins: [ react() ],
// TODO: Rename any files which use JSX to .jsx.
// This is a temporary workaround to allow JSX in .js files but this adds overhead
// as every js file is interpreted as a JSX file evn if it doesn't contain JSX.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we get this to merge, create a follow up issue to do this work to improve overall performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant