-
Notifications
You must be signed in to change notification settings - Fork 309
Enhancement/10145-vitest-migration #10858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enhancement/10091-storybook-dependencies-latest-nodejs
Are you sure you want to change the base?
Enhancement/10145-vitest-migration #10858
Conversation
…il/whenScopesGranted.test.js.
…ViewContext.test.js.
… and fix all assets/js/util/ tests.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
plugins: [ react() ], | ||
// TODO: Rename any files which use JSX to .jsx. | ||
// This is a temporary workaround to allow JSX in .js files but this adds overhead | ||
// as every js file is interpreted as a JSX file evn if it doesn't contain JSX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we get this to merge, create a follow up issue to do this work to improve overall performance.
Summary
Addresses issue:
Relevant technical choices
VITest base infra with 52% of tests fixed and passing.
An early note the current suite is running slower than Jest was. Although this could be todo with the number of failing tests still. In another hackathon I can get this ready for review.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist