Refactor bootstrap.js for E2E #10860
Conversation
tests/e2e/config/bootstrap.js
Outdated
| // Before every test suite run, delete all content created by the test. This ensures | ||
| // other posts/comments/etc. aren't dirtying tests and tests don't depend on | ||
| // each other's side-effects. | ||
| // Before every test suite run, delete all content created by the test. |
There was a problem hiding this comment.
Please restore the full comment here.
tests/e2e/config/bootstrap.js
Outdated
| @@ -364,25 +382,21 @@ async function observeRestResponse( res ) { | |||
| if ( res.url().match( 'wp-json' ) ) { | |||
| const data = [ res.status(), res.request().method(), res.url() ]; | |||
|
|
|||
| // The response may fail to resolve if the test ends before it completes. | |||
There was a problem hiding this comment.
Please restore this comment.
tests/e2e/config/bootstrap.js
Outdated
| // At this point, any unexpected message will result in a test failure. | ||
|
|
||
| // Check if it's raised by the AMP plugin. | ||
| // Check if it's raised by the AMP plugin |
There was a problem hiding this comment.
Please restore the removed/modified comment here.
tests/e2e/config/bootstrap.js
Outdated
| // removed once the associated ticket has been closed. | ||
| // | ||
| // See: https://core.trac.wordpress.org/ticket/47183 | ||
| // Check if the message should be ignored |
There was a problem hiding this comment.
This comment should end in a full stop:
| // Check if the message should be ignored | |
| // Check if the message should be ignored. |
tests/e2e/config/bootstrap.js
Outdated
| * Array of console messages to ignore. | ||
| */ | ||
| const IGNORE_CONSOLE_MESSAGES = [ | ||
| // An exception is made for _blanket_ deprecation warnings |
There was a problem hiding this comment.
Please restore the full comment for this check, as illustrated below.
There are other checks which have also had their comments truncated or modified as part of this refactor. Please review all of the checks, and restore their full comments.
| // An exception is made for _blanket_ deprecation warnings | |
| // An exception is made for _blanket_ deprecation warnings: Those | |
| // which log regardless of whether a deprecated feature is in use. |
|
Thank you @techanvil for looking into the code review. I have addressed the comments regarding comments restoration and also restored at some other places where those were missing. Assigning this to you to review the changes. Thanks again! |
Summary
Addresses issue:
tests/e2e/config/bootstrap.js#10369Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist