Skip to content

Rename handleDialog prop to handleCancel in ModalDialog #10884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 12, 2025
Merged

Rename handleDialog prop to handleCancel in ModalDialog #10884

merged 6 commits into from
Jun 12, 2025

Conversation

nfmohit
Copy link
Collaborator

@nfmohit nfmohit commented Jun 6, 2025 •
edited by hussain-t
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025 •
edited
Loading

Size Change: +27 B (0%)

Total Size: 2.13 MB

ℹ️ View Unchanged
Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 62.8 kB 0 B
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB 0 B
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B 0 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.47 kB 0 B
./dist/assets/js/32-********************.js 2.76 kB 0 B
./dist/assets/js/33-********************.js 2.25 kB 0 B
./dist/assets/js/34-********************.js 3.64 kB 0 B
./dist/assets/js/35-********************.js 936 B 0 B
./dist/assets/js/36-********************.js 893 B 0 B
./dist/assets/js/37-********************.js 1.83 kB 0 B
./dist/assets/js/38-********************.js 3.12 kB 0 B
./dist/assets/js/analytics-advanced-tracking-********************.js 903 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 492 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/block-editor-plugin/index.js 8.42 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/common/editor-styles.js 492 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/contribute-with-google/index.js 9.47 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 8.95 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/subscribe-with-google/index.js 9.47 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 8.96 kB 0 B
./dist/assets/js/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
./dist/assets/js/blocks/sign-in-with-google/editor-styles.js 492 B 0 B
./dist/assets/js/blocks/sign-in-with-google/index.js 18.1 kB 0 B
./dist/assets/js/googlesitekit-activation-********************.js 24.3 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 57.8 kB +2 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 37.1 kB +3 B (+0.01%)
./dist/assets/js/googlesitekit-api-********************.js 10.4 kB 0 B
./dist/assets/js/googlesitekit-components-********************.js 6.47 kB 0 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB 0 B
./dist/assets/js/googlesitekit-data-********************.js 2.38 kB 0 B
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.13 kB 0 B
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB 0 B
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.9 kB 0 B
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.2 kB 0 B
./dist/assets/js/googlesitekit-datastore-user-********************.js 27.2 kB 0 B
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 68.7 kB +2 B (0%)
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B 0 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 977 B 0 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B 0 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 717 B 0 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B 0 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B 0 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.36 kB 0 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B 0 B
./dist/assets/js/googlesitekit-i18n-********************.js 4.16 kB 0 B
./dist/assets/js/googlesitekit-main-dashboard-********************.js 149 kB 0 B
./dist/assets/js/googlesitekit-metric-selection-********************.js 56 kB +2 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js 24.1 kB 0 B
./dist/assets/js/googlesitekit-modules-ads-********************.js 52.8 kB +1 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 134 kB +2 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 209 kB 0 B
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 26.6 kB 0 B
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 48.9 kB 0 B
./dist/assets/js/googlesitekit-modules-search-console-********************.js 75.2 kB 0 B
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 36.3 kB 0 B
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 33.1 kB 0 B
./dist/assets/js/googlesitekit-notifications-********************.js 55.5 kB 0 B
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B 0 B
./dist/assets/js/googlesitekit-settings-********************.js 136 kB +5 B (0%)
./dist/assets/js/googlesitekit-splash-********************.js 75.2 kB +2 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.4 kB +3 B (+0.01%)
./dist/assets/js/googlesitekit-vendor-********************.js 313 kB 0 B
./dist/assets/js/googlesitekit-widgets-********************.js 112 kB +1 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 65.3 kB +2 B (0%)
./dist/assets/js/runtime-********************.js 1.32 kB 0 B

compressed-size-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025 •
edited
Loading

Build files for ae85037 have been deleted.

hussain-t
hussain-t approved these changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @nfmohit! LGTM 👍

Note: I've verified that the VRT failures are unrelated to this PR.

@hussain-t hussain-t merged commit 17ee5b2 into develop Jun 12, 2025
21 of 22 checks passed
@hussain-t hussain-t deleted the enhancement/#10671-refactor-modaldialog branch June 12, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussain-t hussain-t hussain-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfmohit @hussain-t