Bug/10903 Temp fix AS Setup Flow #10904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their own settings.
…changed and payment option is valid.
…n the query string.
Co-authored-by: Matthew Riley MacPherson <[email protected]>
…dule-feature-flag Remove `rrmModule` feature flag
…c-requires-since Refactor jsdoc requires since rule
…segmentation-banner-dismiss Follow up: Fix audience segmentation banner dismissal.
…otification-areas Enhancement/10806 Restructure Notification Areas
…rect-imports-createReducer Infrastructure/10230 replace direct imports create reducer
…terruptions in setup flow.
|
Build files for 702bac7 have been deleted. |
|
Size Change: +122 B (+0.01%) Total Size: 2.13 MB ℹ️ View Unchanged
|
…terruptions in setup flow.
eugene-manuilov
requested changes
Jun 10, 2025
| @@ -720,7 +720,7 @@ export const registerWidgets = ( widgets ) => { | |||
| export const ANALYTICS_4_NOTIFICATIONS = { | |||
| [ AUDIENCE_SEGMENTATION_SETUP_CTA_NOTIFICATION ]: { | |||
| Component: AudienceSegmentationSetupCTABanner, | |||
| priority: PRIORITY.SETUP_CTA_LOW, | |||
| priority: 130, // TODO: Revert this temporary priority after fixing Issue #10890. | |||
There was a problem hiding this comment.
@jimmymadon, could you please use a fully qualified link to the issue instead of referencing it by the number? Also, can you add the previous value to the comment so the one who will work on it next time will know which was the right priorities?
|
Closing this PR in favour of the cleaner #10909 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…terruptions in setup flow.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist