Skip to content

Remove unused hideOnMobile column definition property. #10906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

ankitrox
Copy link
Collaborator

@ankitrox ankitrox commented Jun 10, 2025

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Jun 10, 2025

Size Change: -554 B (-0.03%)

Total Size: 2.13 MB

ℹ️ View Unchanged
Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 62.8 kB -26 B (-0.04%)
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB 0 B
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B 0 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.44 kB -28 B (-0.33%)
./dist/assets/js/32-********************.js 2.76 kB 0 B
./dist/assets/js/33-********************.js 2.25 kB 0 B
./dist/assets/js/34-********************.js 3.64 kB 0 B
./dist/assets/js/35-********************.js 936 B 0 B
./dist/assets/js/36-********************.js 893 B 0 B
./dist/assets/js/37-********************.js 1.83 kB 0 B
./dist/assets/js/38-********************.js 3.12 kB 0 B
./dist/assets/js/analytics-advanced-tracking-********************.js 903 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 492 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/block-editor-plugin/index.js 8.42 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/common/editor-styles.js 492 B 0 B
./dist/assets/js/blocks/reader-revenue-manager/contribute-with-google/index.js 9.47 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 8.95 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/subscribe-with-google/index.js 9.47 kB 0 B
./dist/assets/js/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 8.96 kB 0 B
./dist/assets/js/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
./dist/assets/js/blocks/sign-in-with-google/editor-styles.js 492 B 0 B
./dist/assets/js/blocks/sign-in-with-google/index.js 18.1 kB 0 B
./dist/assets/js/googlesitekit-activation-********************.js 24.3 kB 0 B
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 57.8 kB 0 B
./dist/assets/js/googlesitekit-adminbar-********************.js 37.1 kB 0 B
./dist/assets/js/googlesitekit-api-********************.js 10.4 kB 0 B
./dist/assets/js/googlesitekit-components-********************.js 6.47 kB 0 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB 0 B
./dist/assets/js/googlesitekit-data-********************.js 2.38 kB 0 B
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.13 kB 0 B
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB 0 B
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.9 kB 0 B
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.2 kB 0 B
./dist/assets/js/googlesitekit-datastore-user-********************.js 27.2 kB 0 B
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 68.7 kB 0 B
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B 0 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 977 B 0 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B 0 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 717 B 0 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B 0 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B 0 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.36 kB 0 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B 0 B
./dist/assets/js/googlesitekit-i18n-********************.js 4.16 kB 0 B
./dist/assets/js/googlesitekit-main-dashboard-********************.js 149 kB 0 B
./dist/assets/js/googlesitekit-metric-selection-********************.js 56 kB 0 B
./dist/assets/js/googlesitekit-modules-********************.js 24.1 kB 0 B
./dist/assets/js/googlesitekit-modules-ads-********************.js 52.8 kB 0 B
./dist/assets/js/googlesitekit-modules-adsense-********************.js 133 kB -115 B (-0.09%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 209 kB -123 B (-0.06%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 26.6 kB 0 B
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 48.9 kB 0 B
./dist/assets/js/googlesitekit-modules-search-console-********************.js 75.1 kB -117 B (-0.16%)
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 36.3 kB 0 B
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 33.1 kB 0 B
./dist/assets/js/googlesitekit-notifications-********************.js 55.5 kB 0 B
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B 0 B
./dist/assets/js/googlesitekit-settings-********************.js 136 kB 0 B
./dist/assets/js/googlesitekit-splash-********************.js 75.2 kB 0 B
./dist/assets/js/googlesitekit-user-input-********************.js 48.4 kB 0 B
./dist/assets/js/googlesitekit-vendor-********************.js 313 kB 0 B
./dist/assets/js/googlesitekit-widgets-********************.js 112 kB 0 B
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 65.1 kB -145 B (-0.22%)
./dist/assets/js/runtime-********************.js 1.32 kB 0 B

compressed-size-action

Copy link

github-actions bot commented Jun 10, 2025

Build files for 47e77d7 have been deleted.

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankitrox, this is looking good. Two points:

  1. Please remove the unused SCSS style as per my comment.
  2. Please can you update the QAB to make it clearer where the focus of the smoke testing should lie. We don't need to spend time smoke testing the entire plugin, only those parts which display the ReportTable component.

@ankitrox
Copy link
Collaborator Author

Thank you @techanvil for reviewing the PR. I have removed the unsed style as suggested and also updated the QAB as per instructions and to focus only on the area which is being changed in this PR.

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankitrox, that's great. LGTM!

Note that I've confirmed the failing E2E and VRT tests are unrelated to this PR.

@techanvil techanvil merged commit 9f7f22e into develop Jun 12, 2025
22 of 26 checks passed
@techanvil techanvil deleted the enhancement/10783-remove-hideOnMobile-prop branch June 12, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants