Skip to content

Extract Audience_Utilities from Analytics_4.#12106

Merged
eugene-manuilov merged 5 commits into
developfrom
enhancement/9229-analytics_4_audience
Feb 2, 2026
Merged

Extract Audience_Utilities from Analytics_4.#12106
eugene-manuilov merged 5 commits into
developfrom
enhancement/9229-analytics_4_audience

Conversation

@arkaitzbitorika

@arkaitzbitorika arkaitzbitorika commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses issue:

Relevant technical choices

  • Created Audience_Utilities with audience-related code from Analytics_4.
  • Created Audience_UtilitiesTest with unittests for Audience_Utilities.
  • Removed audience related code from Analytics_4 and made it use Audience_Utilities instead.

PR Author Checklist

  • [x ] My code is tested and passes existing unit tests.
  • [ x] My code has an appropriate set of unit tests which all pass.
  • [ x] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • [x ] My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • [x ] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@arkaitzbitorika arkaitzbitorika self-assigned this Jan 27, 2026
@arkaitzbitorika arkaitzbitorika added the Type: Enhancement Improvement of an existing feature label Jan 27, 2026
@github-actions

github-actions Bot commented Jan 27, 2026

Copy link
Copy Markdown

Build files for 847f433 have been deleted.

@aaemnnosttv aaemnnosttv removed the Type: Enhancement Improvement of an existing feature label Jan 29, 2026
@arkaitzbitorika arkaitzbitorika force-pushed the enhancement/9229-analytics_4_audience branch from 3285401 to aa25a72 Compare January 30, 2026 15:05
@arkaitzbitorika

Copy link
Copy Markdown
Collaborator Author

Verified that the failing E2E tests pass in my local environment.

@eugene-manuilov eugene-manuilov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugene-manuilov eugene-manuilov merged commit 7de87eb into develop Feb 2, 2026
25 of 26 checks passed
@eugene-manuilov eugene-manuilov deleted the enhancement/9229-analytics_4_audience branch February 2, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants