Enhancement/#12005 - Implement RRM policy violations dashboard notifications#12117
Merged
techanvil merged 24 commits intoFeb 2, 2026
Merged
Conversation
…ring and behavior for various content policy violation scenarios.
…y rendering of extreme and moderate/high severity notifications.
…venue manager module.
…t policy violation handling.
…owcase various content policy violation scenarios.
…postrophes for consistency in violation messages.
… severity in the reader revenue manager module.
|
Storybook is ready:
|
|
Size Change: +3.41 kB (+0.15%) Total Size: 2.27 MB
ℹ️ View Unchanged
|
|
Build files for 693b0bf have been deleted. |
techanvil
requested changes
Jan 28, 2026
techanvil
left a comment
techanvil
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @hussain-t, this is looking good but need a few changes. Please take a look.
…ction for notification copy and remove redundant code. Simplify dismiss options handling based on content policy state.
…ons in Reader Revenue Manager.
…date notification types and messages based on content policy states.
…utton assertions and consolidate requirement checks into parameterized tests for improved readability and maintainability.
…ification visibility. Refactor notification checks in Reader Revenue Manager module.
Collaborator
Author
|
Thanks for the kind review, @techanvil! Back to you for another pass. |
techanvil
requested changes
Jan 30, 2026
techanvil
left a comment
techanvil
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @hussain-t. This could use a few more changes, please see my comments.
…tests from the Reader Revenue Manager module.
…within the component dir.
…ed tests, and story files from the Reader Revenue Manager module.
Collaborator
Author
|
Thanks for the kind review, @techanvil! I've addressed the comment. Back to you for another pass. |
techanvil
approved these changes
Feb 2, 2026
techanvil
left a comment
techanvil
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, Hussain. That's LGTM.
✅
Note that I've confirmed the failing VRT test is unrelated to this PR.
techanvil
deleted the
enhancement/#12005-rrm-policy-violation-notification
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist