Skip to content

Include content policy state in RRM setup success notification GA events.#12126

Merged
nfmohit merged 4 commits into
developfrom
enhancement/12104-rrm-setup-success-policy-violation-ga-events
Feb 3, 2026
Merged

Include content policy state in RRM setup success notification GA events.#12126
nfmohit merged 4 commits into
developfrom
enhancement/12104-rrm-setup-success-policy-violation-ga-events

Conversation

@techanvil

@techanvil techanvil commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions

Copy link
Copy Markdown

Storybook is ready:

@github-actions

github-actions Bot commented Jan 29, 2026

Copy link
Copy Markdown

Build files for 835f284 have been deleted.

@nfmohit nfmohit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @techanvil!

I've just left one comment for your consideration.

);
} );

describe.each( [

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these tests be nested under GA event tracking? Also, I think we may be able to combine both test cases into one. WDYT?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nahid - they should be under GA event tracking. Re. combining the tests - I did start off taking that approach, but the amount of conditionality in the tests made me decide to separate them.

However, I've taken another look and refactored them to combine, and I think it's OK. Please see what you think.

@nfmohit nfmohit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @techanvil!

@nfmohit nfmohit merged commit a7abfdc into develop Feb 3, 2026
26 of 29 checks passed
@nfmohit nfmohit deleted the enhancement/12104-rrm-setup-success-policy-violation-ga-events branch February 3, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants