Add new invite email template#12130
Merged
tofumatt merged 9 commits intoFeb 11, 2026
Merged
Conversation
|
Storybook is ready:
|
|
Build files for 9676996 have been deleted. |
benbowler
force-pushed
the
enhancement/11851-add-invitation-email-template
branch
from
83d24dc to
22c6c2e
Compare
…or additional emails in this sprint.
benbowler
changed the title
tofumatt
requested changes
Feb 3, 2026
tofumatt
left a comment
tofumatt
left a comment
Collaborator
There was a problem hiding this comment.
One question about the asset strings here, and a few text comments/suggestions, but otherwise this looks good 👍🏻
Comment on lines
+30
to
+54
| /** | ||
| * Asset paths mapping. | ||
| * | ||
| * Maps asset filenames to their versioned folder paths. | ||
| * Format: 'asset-filename.png' => 'version/template-name' | ||
| * | ||
| * @since n.e.x.t | ||
| * @var array | ||
| */ | ||
| const EMAIL_ASSET_PATHS = array( | ||
| // email-report assets (1.168.0). | ||
| 'site-kit-logo.png' => '1.168.0/email-report', | ||
| 'shooting-stars-graphic.png' => '1.168.0/email-report', | ||
| 'icon-conversions.png' => '1.168.0/email-report', | ||
| 'icon-growth.png' => '1.168.0/email-report', | ||
| 'icon-link-arrow.png' => '1.168.0/email-report', | ||
| 'icon-search.png' => '1.168.0/email-report', | ||
| 'icon-views.png' => '1.168.0/email-report', | ||
| 'icon-visitors.png' => '1.168.0/email-report', | ||
| 'conversions-timeline-green.png' => '1.168.0/email-report', | ||
| 'conversions-timeline-red.png' => '1.168.0/email-report', | ||
| 'notification-icon-star.png' => '1.168.0/email-report', | ||
| // invitation-email assets (1.172.0). | ||
| 'invitation-envelope-graphic.png' => '1.172.0/invitation-email', | ||
| ); |
Collaborator
There was a problem hiding this comment.
Is there some more documentation somewhere on how this works or how these versions should be updated? I'm surprised we're not using n.e.x.t here. How do developers know how to add new assets here?
Collaborator
Author
There was a problem hiding this comment.
I had already discussed a refactor of this to move away from linking assets to version numbers and to simplify the asset loading by using a key-based asset map. Lmk what you think of this refactor.
…add-invitation-email-template.
Co-authored-by: Matthew Riley MacPherson <hi@tofumatt.com>
Co-authored-by: Matthew Riley MacPherson <hi@tofumatt.com>
…bust new Email_Assets class.
Collaborator
Author
|
Thanks @tofumatt. I have asked @sigal-teller to review/approve the copy changes, as they will need to be brought back to Figma to prevent being caught in QA later. |
Co-authored-by: Matthew Riley MacPherson <hi@tofumatt.com>
…ate.php Co-authored-by: Matthew Riley MacPherson <hi@tofumatt.com>
…add-invitation-email-template.
tofumatt
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
As part of this ticket, I'd worked on some initial optimisation to allow for future simple email templates that follow the same design as this one (three will be added to this feature in this epic). I've created shared simple template methods throughout the render process and also included copy to be used in the plain text renderer in a centralised class
Body_Content_MapTest.This can be extended upon in upcoming tickets, we should consider sharing the template between each similar email with only configurable body copy within a centralised class.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist