Enhancement/12578 side panel goal drivers#12669
Open
zutigrm wants to merge 39 commits into
Open
Conversation
…ection' into enhancement/12578-side-panel-goal-drivers.
zutigrm
changed the base branch from
develop
to
enhancement/12528-goal-drivers-section
📚 Storybook for b8d602b: 📦 Build files for b8d602b:
🎭 Playwright reports for b8d602b: |
…side-panel-goal-drivers.
|
Size Change: +8.67 kB (+0.38%) Total Size: 2.31 MB 📦 View Changed
ℹ️ View Unchanged
|
zutigrm
changed the base branch from
enhancement/12528-goal-drivers-section
to
develop
…ection' into enhancement/12578-side-panel-goal-drivers.
zutigrm
changed the base branch from
develop
to
enhancement/12528-goal-drivers-section
eugene-manuilov
requested changes
May 8, 2026
| const SiteGoalsSelectionPanel: FC = () => { | ||
| const isOpen = useSelect( | ||
| ( select: Select ) => | ||
| select( CORE_UI ).getValue( SITE_GOALS_SELECTION_PANEL_OPENED_KEY ), |
Collaborator
There was a problem hiding this comment.
@zutigrm no CORE_UI nor CORE_FORMS must be used. This is Analytics-4 functionality and MUST be driven by the Analytics-4 datastore.
Collaborator
Author
There was a problem hiding this comment.
We have an issue to standardize the side panel opening logic in #12446, creating a new (selectors/actions) in this issue, will just increase the review surface of already big PR, and make it more complicated when we start migrating the logic. Also Site Goals and Audience Segmentation are both GA4 module features, so it will be better to align them both in separate issue, and have proper definition for that, as they use the same approach like other side panels at the moment
zutigrm
commented
May 13, 2026
Collaborator
Author
There was a problem hiding this comment.
quick change made to lower the complexity which reached maximum and lintern was flagging the file
Base automatically changed from
enhancement/12528-goal-drivers-section
to
develop
May 14, 2026 18:56
…side-panel-goal-drivers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist