Update the splash screen for mobile viewports.#12721
Open
ankitrox wants to merge 7 commits into
Open
Conversation
🎭 Playwright reports for 23edbef: 📚 Storybook for 23edbef: 📦 Build files for 23edbef:
|
|
Size Change: +52.5 kB (+2.28%) Total Size: 2.36 MB 📦 View Changed
ℹ️ View Unchanged
|
techanvil
requested changes
May 14, 2026
Collaborator
There was a problem hiding this comment.
Please rename this file to assets/svg/graphics/splash-screenshot-mobile.svg.
Collaborator
There was a problem hiding this comment.
Let's wrap this right property in a media query to prevent the background image from obscuring the content in some narrow desktop viewports (e.g. 1024x768, as seen in the screenshot below).
Suggested change
| @media (min-width: $bp-xlarge) { | |
| right: 0; | |
| } |
Comment on lines
+143
to
+154
| @media (max-width: $bp-desktop) { | ||
| align-items: content; | ||
| display: flex; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| @media (max-width: $bp-tablet) { | ||
| .googlesitekit-setup__splash-graphic-screenshot { | ||
| max-height: none; | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
I'm not sure if I'm missing something, but these styles don't seem to be needed. Also, content isn't a valid value for the align-items property.
Suggested change
| @media (max-width: $bp-desktop) { | |
| align-items: content; | |
| display: flex; | |
| overflow: hidden; | |
| } | |
| @media (max-width: $bp-tablet) { | |
| .googlesitekit-setup__splash-graphic-screenshot { | |
| max-height: none; | |
| } | |
| } |
Comment on lines
+160
to
+163
|
|
||
| .googlesitekit-setup__splash-graphic-screenshot { | ||
| bottom: 0; | ||
| } |
Collaborator
There was a problem hiding this comment.
Again, I might be missing something here but this doesn't seem needed:
Suggested change
| .googlesitekit-setup__splash-graphic-screenshot { | |
| bottom: 0; | |
| } |
Collaborator
Author
There was a problem hiding this comment.
I added it when I was styling the screenshot on mobile, but seems like this is not required. Removed it.
Comment on lines
133
to
136
| @@ -138,9 +137,37 @@ | |||
Collaborator
There was a problem hiding this comment.
I think these properties should also be removed:
Suggested change
| margin-bottom: $grid-gap-desktop; |
Collaborator
Author
|
Thanks @techanvil for reviewing the PR. I've addressed the feedback and sending your way for another review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist