Skip to content

Migrate top level JS files to TS.#12768

Merged
hussain-t merged 5 commits into
developfrom
enhancement/12591-migrate-js-to-ts-1
Jun 8, 2026
Merged

Migrate top level JS files to TS.#12768
hussain-t merged 5 commits into
developfrom
enhancement/12591-migrate-js-to-ts-1

Conversation

@abdelmalekkkkk

@abdelmalekkkkk abdelmalekkkkk commented May 21, 2026 •
edited by hussain-t
Loading

Copy link
Copy Markdown
Contributor

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/12591-migrate-js-to-ts-1 branch from 295d067 to 77264d2 Compare May 21, 2026 13:11
@github-actions

github-actions Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

🎭 Playwright reports for 21838cc:

  • Reports have been deleted.

📦 Build files for 21838cc:

  • Build files have been deleted.

📚 Storybook for 21838cc:

  • Storybook has been deleted.

abdelmalekkkkk
abdelmalekkkkk commented May 21, 2026
View reviewed changes
Comment thread assets/js/api-fetch-shim.ts
abdelmalekkkkk
abdelmalekkkkk commented May 21, 2026
View reviewed changes
Comment thread assets/js/googlesitekit-polyfills.ts
@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/12591-migrate-js-to-ts-1 branch from 77264d2 to d11ea97 Compare May 21, 2026 13:24
@github-actions

github-actions Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Size Change: +1.23 kB (+0.04%)

Total Size: 2.89 MB

📦 View Changed
Filename Size Change
dist/assets/js/googlesitekit-notifications-********************.js 69.1 kB +1.23 kB (+1.81%)
ℹ️ View Unchanged
Filename Size Change
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 42.7 kB 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 5.8 kB 0 B
dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 5.01 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 5.81 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 5 kB 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/sign-in-with-google/index.js 18.5 kB 0 B
dist/assets/css/googlesitekit-admin-css-********************.min.css 70.9 kB 0 B
dist/assets/css/googlesitekit-adminbar-css-********************.min.css 12.3 kB 0 B
dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 851 B 0 B
dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.9 kB 0 B
dist/assets/js/146-********************.js 960 B 0 B
dist/assets/js/201-********************.js 2.85 kB 0 B
dist/assets/js/273-********************.js 52.5 kB 0 B
dist/assets/js/314-********************.js 100 kB 0 B
dist/assets/js/315-********************.js 3.08 kB 0 B
dist/assets/js/379-********************.js 3.7 kB 0 B
dist/assets/js/397-********************.js 477 kB 0 B
dist/assets/js/590-********************.js 1.88 kB 0 B
dist/assets/js/640-********************.js 2.35 kB 0 B
dist/assets/js/909-********************.js 1.01 kB 0 B
dist/assets/js/analytics-advanced-tracking-********************.js 404 B 0 B
dist/assets/js/googlesitekit-activation-********************.js 24.9 kB +7 B (+0.03%)
dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 60.9 kB +35 B (+0.06%)
dist/assets/js/googlesitekit-admin-pointers-tracking-********************.js 5.36 kB -2 B (-0.04%)
dist/assets/js/googlesitekit-adminbar-********************.js 36.3 kB +182 B (+0.5%)
dist/assets/js/googlesitekit-api-********************.js 8.04 kB +2 B (+0.02%)
dist/assets/js/googlesitekit-block-tracking-********************.js 5.56 kB +1 B (+0.02%)
dist/assets/js/googlesitekit-components-********************.js 5.64 kB +8 B (+0.14%)
dist/assets/js/googlesitekit-consent-mode-********************.js 26 kB 0 B
dist/assets/js/googlesitekit-data-********************.js 1.76 kB -4 B (-0.23%)
dist/assets/js/googlesitekit-datastore-forms-********************.js 7.2 kB +3 B (+0.04%)
dist/assets/js/googlesitekit-datastore-location-********************.js 1.52 kB 0 B
dist/assets/js/googlesitekit-datastore-pdf-********************.js 1.19 kB 0 B
dist/assets/js/googlesitekit-datastore-site-********************.js 18.7 kB -39 B (-0.21%)
dist/assets/js/googlesitekit-datastore-ui-********************.js 7.35 kB -5 B (-0.07%)
dist/assets/js/googlesitekit-datastore-user-********************.js 23.2 kB -72 B (-0.31%)
dist/assets/js/googlesitekit-entity-dashboard-********************.js 74.2 kB +3 B (0%)
dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 2.35 kB 0 B
dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 1.12 kB 0 B
dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 2.34 kB 0 B
dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 2.3 kB 0 B
dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 2.22 kB 0 B
dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 2.44 kB 0 B
dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.08 kB 0 B
dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 2.44 kB 0 B
dist/assets/js/googlesitekit-i18n-********************.js 4.43 kB 0 B
dist/assets/js/googlesitekit-key-metrics-setup-********************.js 54.5 kB +379 B (+0.7%)
dist/assets/js/googlesitekit-main-dashboard-********************.js 177 kB +193 B (+0.11%)
dist/assets/js/googlesitekit-metric-selection-********************.js 60 kB +40 B (+0.07%)
dist/assets/js/googlesitekit-modules-********************.js 26.4 kB +434 B (+1.67%)
dist/assets/js/googlesitekit-modules-ads-********************.js 47.5 kB +520 B (+1.11%)
dist/assets/js/googlesitekit-modules-adsense-********************.js 138 kB +216 B (+0.16%)
dist/assets/js/googlesitekit-modules-analytics-4-********************.js 205 kB +427 B (+0.21%)
dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 23.4 kB +87 B (+0.37%)
dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 52.9 kB +263 B (+0.5%)
dist/assets/js/googlesitekit-modules-search-console-********************.js 66 kB +477 B (+0.73%)
dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 34 kB +242 B (+0.72%)
dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.8 kB +503 B (+1.66%)
dist/assets/js/googlesitekit-polyfills-********************.js 227 B -1 B (-0.44%)
dist/assets/js/googlesitekit-settings-********************.js 136 kB +361 B (+0.27%)
dist/assets/js/googlesitekit-splash-********************.js 80.9 kB +100 B (+0.12%)
dist/assets/js/googlesitekit-user-input-********************.js 52.7 kB +208 B (+0.4%)
dist/assets/js/googlesitekit-vendor-********************.js 314 kB 0 B
dist/assets/js/googlesitekit-vendor-lazy-pdf-********************.js 3.05 kB 0 B
dist/assets/js/googlesitekit-widgets-********************.js 104 kB +46 B (+0.04%)
dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.7 kB -278 B (-0.45%)
dist/assets/js/runtime-********************.js 1.95 kB 0 B

compressed-size-action

@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/12591-migrate-js-to-ts-1 branch from d9784a5 to b9d8cf1 Compare May 22, 2026 11:36
@abdelmalekkkkk abdelmalekkkkk force-pushed the enhancement/12591-migrate-js-to-ts-1 branch from b9d8cf1 to 52e8d7d Compare May 25, 2026 13:07
@hussain-t
Merge remote-tracking branch 'origin/develop' into enhancement/12591-…
21838cc 
…migrate-js-to-ts-1.

# Conflicts:
#	package.json
hussain-t
hussain-t approved these changes Jun 8, 2026
View reviewed changes

@hussain-t hussain-t left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abdelmalekkkkk! LGTM 👍

@hussain-t hussain-t merged commit dffc35a into develop Jun 8, 2026
45 of 46 checks passed
@hussain-t hussain-t deleted the enhancement/12591-migrate-js-to-ts-1 branch June 8, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hussain-t hussain-t hussain-t approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abdelmalekkkkk @hussain-t