Ensure the ToS can be accepted / rejected following an initial rejection.#12795
Merged
Conversation
techanvil
changed the title
techanvil
force-pushed
the
enhancement/12377-fix-tos-resubmission
branch
from
1647a46 to
acfa613
Compare
|
Size Change: 0 B Total Size: 2.39 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
This is a fix to ensure that the ToS screen can be accepted / rejected in the case where the user initially rejects the ToS, is returned to the Analytics setup screen with an error, and then goes back to the ToS screen to resubmit the form.
The solution is to ensure the account ticket ID transient isn't deleted in the case of an error, as we'll still need it when returning to the Analytics setup screen after the user revisits the ToS screen.
This change isn't behind the
setupFlowRefreshfeature flag, as it won't impact the non-SFR flow - the transient will expire after 15 mins, and is overridden when entering the account creation flow again anyway.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist