Skip to content

Enhancement/12801 trigger custom dimension#12860

Merged
tofumatt merged 51 commits into
developfrom
enhancement/12801-trigger-custom-dimension
Jun 10, 2026
Merged

Enhancement/12801 trigger custom dimension#12860
tofumatt merged 51 commits into
developfrom
enhancement/12801-trigger-custom-dimension

Conversation

@zutigrm

@zutigrm zutigrm commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📚 Storybook for dea2543:

  • Storybook has been deleted.

📦 Build files for dea2543:

  • Build files have been deleted.

🎭 Playwright reports for dea2543:

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Size Change: +4.3 kB (+0.15%)

Total Size: 2.91 MB

📦 View Changed
Filename Size Change
dist/assets/js/googlesitekit-main-dashboard-********************.js 181 kB +2.15 kB (+1.2%)
dist/assets/js/googlesitekit-modules-analytics-4-********************.js 209 kB +2.15 kB (+1.04%)
ℹ️ View Unchanged
Filename Size Change
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 42.7 kB 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 5.8 kB 0 B
dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 5.01 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 5.81 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 5 kB 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/sign-in-with-google/index.js 18.5 kB 0 B
dist/assets/css/googlesitekit-admin-css-********************.min.css 71.4 kB +16 B (+0.02%)
dist/assets/css/googlesitekit-adminbar-css-********************.min.css 12.3 kB 0 B
dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 851 B 0 B
dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.9 kB 0 B
dist/assets/js/146-********************.js 960 B 0 B
dist/assets/js/201-********************.js 2.85 kB 0 B
dist/assets/js/273-********************.js 52.5 kB 0 B
dist/assets/js/314-********************.js 100 kB 0 B
dist/assets/js/315-********************.js 3.08 kB 0 B
dist/assets/js/379-********************.js 3.7 kB 0 B
dist/assets/js/397-********************.js 477 kB 0 B
dist/assets/js/590-********************.js 1.88 kB 0 B
dist/assets/js/640-********************.js 2.35 kB 0 B
dist/assets/js/909-********************.js 1.01 kB 0 B
dist/assets/js/analytics-advanced-tracking-********************.js 404 B 0 B
dist/assets/js/googlesitekit-activation-********************.js 25.1 kB 0 B
dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 61 kB 0 B
dist/assets/js/googlesitekit-admin-pointers-tracking-********************.js 5.36 kB 0 B
dist/assets/js/googlesitekit-adminbar-********************.js 36.3 kB 0 B
dist/assets/js/googlesitekit-api-********************.js 8.04 kB 0 B
dist/assets/js/googlesitekit-block-tracking-********************.js 5.55 kB 0 B
dist/assets/js/googlesitekit-components-********************.js 6.21 kB 0 B
dist/assets/js/googlesitekit-consent-mode-********************.js 26 kB 0 B
dist/assets/js/googlesitekit-data-********************.js 1.75 kB 0 B
dist/assets/js/googlesitekit-datastore-forms-********************.js 7.2 kB 0 B
dist/assets/js/googlesitekit-datastore-location-********************.js 1.52 kB 0 B
dist/assets/js/googlesitekit-datastore-pdf-********************.js 1.2 kB 0 B
dist/assets/js/googlesitekit-datastore-site-********************.js 18.8 kB +27 B (+0.14%)
dist/assets/js/googlesitekit-datastore-ui-********************.js 7.36 kB 0 B
dist/assets/js/googlesitekit-datastore-user-********************.js 23.2 kB 0 B
dist/assets/js/googlesitekit-entity-dashboard-********************.js 74.4 kB 0 B
dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 2.35 kB 0 B
dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 1.12 kB 0 B
dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 2.34 kB 0 B
dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 2.3 kB 0 B
dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 2.22 kB 0 B
dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 2.44 kB 0 B
dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.08 kB 0 B
dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 2.44 kB 0 B
dist/assets/js/googlesitekit-i18n-********************.js 4.43 kB 0 B
dist/assets/js/googlesitekit-key-metrics-setup-********************.js 55.1 kB 0 B
dist/assets/js/googlesitekit-metric-selection-********************.js 60.1 kB 0 B
dist/assets/js/googlesitekit-modules-********************.js 27 kB 0 B
dist/assets/js/googlesitekit-modules-ads-********************.js 47.5 kB +30 B (+0.06%)
dist/assets/js/googlesitekit-modules-adsense-********************.js 138 kB 0 B
dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 23.4 kB 0 B
dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 53.5 kB 0 B
dist/assets/js/googlesitekit-modules-search-console-********************.js 66 kB 0 B
dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 34 kB 0 B
dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.9 kB 0 B
dist/assets/js/googlesitekit-notifications-********************.js 69.1 kB 0 B
dist/assets/js/googlesitekit-polyfills-********************.js 228 B 0 B
dist/assets/js/googlesitekit-settings-********************.js 136 kB 0 B
dist/assets/js/googlesitekit-splash-********************.js 82 kB 0 B
dist/assets/js/googlesitekit-user-input-********************.js 52.8 kB 0 B
dist/assets/js/googlesitekit-vendor-********************.js 314 kB 0 B
dist/assets/js/googlesitekit-vendor-lazy-pdf-********************.js 4.04 kB 0 B
dist/assets/js/googlesitekit-widgets-********************.js 104 kB 0 B
dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.7 kB 0 B
dist/assets/js/runtime-********************.js 1.95 kB 0 B

compressed-size-action

@tofumatt tofumatt merged commit 7b04f2a into develop Jun 10, 2026
41 of 42 checks passed
@tofumatt tofumatt deleted the enhancement/12801-trigger-custom-dimension branch June 10, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants