Skip to content

Conversation

@ko1in1u
Copy link
Collaborator

@ko1in1u ko1in1u commented May 9, 2025

This change is Reviewable

@ko1in1u ko1in1u added this to the 1.1.3 milestone May 9, 2025
@ko1in1u ko1in1u requested a review from eric100lin May 9, 2025 07:14
@ko1in1u ko1in1u self-assigned this May 9, 2025
@ko1in1u ko1in1u added the enhancement New feature or request label May 9, 2025
Copy link
Collaborator

@eric100lin eric100lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ko1in1u)


snippet_uiautomator/android/app/src/main/java/com/google/android/mobly/snippet/uiautomator/UiObject2Snippet.java line 412 at r1 (raw file):

            @Override
            public String toString() {
              return String.format("SearchCondition[selector=%s]", childBySelector);

nit: For simple concatenation like this, directly using '+' might be slightly more readable and performant, consider: return "SearchCondition[selector=" + childBySelector + "]";

Code quote:

String.format("SearchCondition[selector=%s]", childBySelector)

@ko1in1u ko1in1u merged commit c762434 into google:main May 12, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants