starlark: add ** operator, **= augmented assignment, and pow() (#631)#632
Open
nickovs wants to merge 1 commit into
Open
starlark: add ** operator, **= augmented assignment, and pow() (#631)#632nickovs wants to merge 1 commit into
nickovs wants to merge 1 commit into
Conversation
…built-in (google#631) Add the ** exponentiation operator and pow() built-in function, bringing Starlark closer to Python's numeric capabilities. Parser: introduce parseFactor/parsePower productions (modeled on Python's grammar) to place unary operators between multiplication and exponentiation in precedence, and to handle right-associativity of **. Scanner: reorder the token enum so that STARSTAR and STARSTAR_EQ are adjacent to the PLUS..GTGT and PLUS_EQ..GTGT_EQ groups, allowing the compiler and VM offset arithmetic to work without special cases. Runtime: Int**Int (non-negative exp) produces exact Int via big.Int.Exp with a 4096-bit result size cap; negative or float exponents produce Float. pow(base, exp, mod) performs modular exponentiation for integer arguments.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Python
**operator,**=augmented assignment operator, andpow()builtin function, addressing issue #631.The implementation follows the design changes laid out in the issue.
The PR includes (hopefully) complete test cases for the new functionality and its Python compatibility, and the documentation has been updated to reflect the changes.