syz-manager: fix nil pointer dereference in VMLess mode #6445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimyn-girgis
force-pushed
the
vmless-nil-pointer-fix
branch
from
adc5738 to
34f763a
Compare
Collaborator
|
LGTM Let's also add a check here that if syzkaller/pkg/mgrconfig/load.go Lines 211 to 212 in 34f763a |
pimyn-girgis
force-pushed
the
vmless-nil-pointer-fix
branch
from
34f763a to
7fea6ca
Compare
When in VMLess mode, reproLoop is not initialized, but we try to dereference it anyways. Check if reproLoop is nil before trying to access it. Fixes google#6420
pimyn-girgis
force-pushed
the
vmless-nil-pointer-fix
branch
from
7fea6ca to
729f401
Compare
a-nogikh
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in VMLess mode, reproLoop is not initialized, but we try to dereference it anyways. Check if reproLoop is nil before trying to access it.
Fixes #6420
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md