Skip to content

syz-manager: fix nil pointer dereference in VMLess mode #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pimyn-girgis merged 2 commits into from
Nov 4, 2025
Merged

syz-manager: fix nil pointer dereference in VMLess mode #6445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d91139b
syz-manager: fix nil pointer dereference in VMLess mode
pimyn-girgis Nov 4, 2025
729f401
pkg/mgrconfig: ensure reproduce is set to false when type is set to none
pimyn-girgis Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/mgrconfig/load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,11 @@ func Complete(cfg *Config) error {
}
cfg.initTimeouts()
cfg.VMLess = cfg.Type == "none"

if cfg.VMLess && cfg.Reproduce {
return fmt.Errorf("if config param type is none, reproduce must be false")
}

return nil
}

Expand Down
3 changes: 2 additions & 1 deletion syz-manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,7 +1343,8 @@ func (mgr *Manager) setPhaseLocked(newPhase int) {
if mgr.phase == newPhase {
panic("repeated phase update")
}
if newPhase == phaseTriagedHub {
// In VMLess mode, mgr.reproLoop is nil.
if newPhase == phaseTriagedHub && mgr.reproLoop != nil {
// Start reproductions.
go mgr.reproLoop.Loop(vm.ShutdownCtx())
}
Expand Down