syz-manager: pkg: skip seeds with mismatching requirements in fuzzing… #5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramosian-glider
force-pushed
the
manager-requires
branch
4 times, most recently
from
b74e713 to
8bc0171
Compare
Member
Author
|
@a-nogikh PTAL |
a-nogikh
reviewed
Dec 2, 2024
ramosian-glider
force-pushed
the
manager-requires
branch
2 times, most recently
from
0fdfb23 to
e11319c
Compare
Member
Author
|
Done |
ramosian-glider
force-pushed
the
manager-requires
branch
2 times, most recently
from
e4f28f2 to
85c84a2
Compare
a-nogikh
previously approved these changes
Dec 3, 2024
ramosian-glider
force-pushed
the
manager-requires
branch
2 times, most recently
from
120a834 to
fca1bea
Compare
a-nogikh
previously approved these changes
Dec 3, 2024
ramosian-glider
force-pushed
the
manager-requires
branch
from
fca1bea to
02cc87d
Compare
a-nogikh
approved these changes
Dec 3, 2024
… mode When running in the test mode, syz-manager already ignores tests that have arch requirements mismatching the target arch. Because the same tests are also used as seeds in the fuzzing mode, skip them likewise, instead of reporting errors if they contain arch-specific syscalls. The code and tests for parsing the requirements is moved from pkg/runtest to pkg/manager.
ramosian-glider
force-pushed
the
manager-requires
branch
from
02cc87d to
b672ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… mode
When running in the test mode, syz-manager already ignores tests that have arch requirements mismatching the target arch.
Because the same tests are also used as seeds in the fuzzing mode, skip them likewise, instead of reporting errors if they contain arch-specific syscalls.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md