Land adrp #5566
Merged
Land adrp #5566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
PTAL |
dvyukov
reviewed
Dec 3, 2024
dvyukov
reviewed
Dec 3, 2024
ramosian-glider
force-pushed
the
land-adrp
branch
from
4594620 to
320260a
Compare
Detect and report ADRP instructions in the linked binaries to avoid crashes inside SyzOS. See google#5565 for more context.
Apply __attribute__((noinline)) to SyzOS API command handlers to prevent overly optimizing them. While at it, rearrange specifiers in guest function declarations
Prevent the compiler from generating a jump table by replacing a switch with a series of if statements. This is ugly, but lets us work around crashes caused by google#5565
This is needed to be able to run alien binaries in tests under qemu-user
ramosian-glider
force-pushed
the
land-adrp
branch
from
320260a to
8a54037
Compare
dvyukov
previously approved these changes
Dec 5, 2024
Glob() doesn't work on 32-bit ARM when run on a 64-bit system under QEMU: https://gitlab.com/qemu-project/qemu/-/issues/263 Not sure whether this is specific to tests running under qemu-user, or the ARM32 executor in the wild as well.
Previously, cross-platform invocations of `syz-executor test` were ignored in the case of a SYZFAIL, and the test was still marked as PASS. Explicitly report a test failure instead.
Make sure regressions in guest code validation are reported during testing rather than fuzzing.
ramosian-glider
force-pushed
the
land-adrp
branch
from
8a54037 to
c0fcc05
Compare
dvyukov
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md