Skip to content

[experiment] pkg/cover: deprecate instrumented and covered columns #5578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tarasmadan wants to merge 1 commit into from
Closed

[experiment] pkg/cover: deprecate instrumented and covered columns #5578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dashboard/app/entities_spanner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ func MergedCoverage(ctx context.Context, ns, periodType string) (*CoverageHistor
select
dateto as targetdate,
duration as days,
cast(sum(instrumented) as INTEGER) as instrumented,
cast(sum(covered) as INTEGER) as covered
cast(sum(array_length(linesinstrumented, 1)) as INTEGER) as instrumented,
cast(sum(array_length(hitcounts, 1)) as INTEGER) as covered
from merge_history join files
on merge_history.session = files.session
where namespace=$1 and duration>=$2 and duration<=$3
Expand Down
4 changes: 2 additions & 2 deletions pkg/cover/heatmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ func filesCoverageWithDetailsStmt(ns, subsystem string, timePeriod coveragedb.Ti
SQL: `
select
commit,
instrumented,
covered,
array_length(linesinstrumented, 1) as instrumented,
array_length(hitcounts, 1) as covered,
files.filepath,
subsystems
from merge_history
Expand Down
Loading