Skip to content

pkg/build: use relative path for fx set directory arg #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glpesk merged 1 commit into from
Dec 9, 2024
Merged

pkg/build: use relative path for fx set directory arg #5585

glpesk merged 1 commit into from
Dec 9, 2024

Conversation

@glpesk
Copy link
Collaborator

@glpesk glpesk commented Dec 9, 2024

This is a fixup to #5543: the --dir argument to fx in the fx set step should be a path relative to the kernel dir, not an absolute path.

@glpesk glpesk requested a review from eepeep December 9, 2024 21:52
@glpesk glpesk added this pull request to the merge queue Dec 9, 2024
Merged via the queue into google:master with commit e4d2aef Dec 9, 2024
17 checks passed
@glpesk glpesk deleted the fx-set-fixup branch December 10, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eepeep eepeep eepeep approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glpesk @eepeep