sys/linux: Additional Descriptions for Mali GPU Driver

[p0-tato]

I noticed that the syscall description for Mali GPU Driver fuzzing was missing the KBASE_IOCTL_KINSTR_PRFCNT_* related ioctls, so I added them.

[tarasmadan]

Thank you! Let's run the tests first.

[p0-tato]

In my environment, I was able to confirm that these syscall descriptions are working properly.

[a-nogikh]

Please fix the following CI errors:

Error: Wrong commit subject format: 'sys/linux: Additional Descriptions for Mali GPU Driver'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details. Regex pattern used to check commit subjects is '^(Revert "|(([a-z0-9/_.-]+|Makefile|CONTRIBUTORS|README.md)(, )?)+:\ [^A-Z].+[^.]$)'.
Error: Wrong commit subject format: 'sys/linux: Additional Descriptions for Mali GPU Driver'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details. Regex pattern used to check commit subjects is '^(Revert "|(([a-z0-9/_.-]+|Makefile|CONTRIBUTORS|README.md)(, )?)+:\ [^A-Z].+[^.]$)'.
Error: Wrong commit subject format: 'Additional descriptions for Mali Driver'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details. Regex pattern used to check commit subjects is '^(Revert "|(([a-z0-9/_.-]+|Makefile|CONTRIBUTORS|README.md)(, )?)+:\ [^A-Z].+[^.]$)'.

[p0-tato]

I'm sorry, I think I might have made a mistake somewhere. Could you please guide me on how to fix the CI? 😢

[a-nogikh]

You just need to change your commit descriptions and force-push the branch, CI tests will run automatically

Merge branch 'master' into master

And that will cause tests to break again :( In our project, we rebase instead of doing merges. Please drop this commit.

[p0-tato]

Thank you so much for your guidance! I have fixed that problem. Could you please check again to confirm?

[a-nogikh]

Now there's one more problem

sys/linux/dev_mali.txt:1:1: The file is not formatted/regenerated. Run 'make generate' and include it into the commit.
Error: The file is not formatted/regenerated. Run 'make generate' and include it into the commit.

Also please notice that now you have 3 commits with identical descriptions:
https://github.com/google/syzkaller/pull/5598/commits

[p0-tato]

Thank you so much! I have reviewed and fixed the issues you pointed out. Could you kindly check again and let me know if everything looks good?

[ramosian-glider]

Please squash "run make extract" into "Additional descriptions for Mali Driver", there's no need to have intermediate patches in the tree.

[p0-tato]

Thank you for your advice. I made the changes as requested.

[ramosian-glider]

@Ji-Hyeon-Jeong, where do these constants actually come from? Is there any source that we can reference here?

[p0-tato]

@ramosian-glider I've extracted all constant from ARM Mali5th Gen Driver r53p0 version, (https://developer.arm.com/downloads/-/mali-drivers/5th-gen-gpu-architecture-kernel).

Every constants I've added come from driver/product/kernel/include/uapi/gpu/arm/midgard/mali_kbase_hwcnt_reader.h(457L~463L & 495L~504L).

Sorry for the delay in checking this 😢 — I had something else to take care of yesterday.

[p0-tato]

@ramosian-glider I noticed that prfcnt_control_cmd was pushed without being updated to ptr64[out, array[int64]], so I made the correction and pushed it again. Could you please check it? Thank you so much!