Skip to content

dashboard/app: provide a text filename to fsck logs #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a-nogikh merged 1 commit into from
Dec 19, 2024
Merged

dashboard/app: provide a text filename to fsck logs #5625

a-nogikh merged 1 commit into from
Dec 19, 2024

Conversation

@FlorentRevest
Copy link
Collaborator

@FlorentRevest FlorentRevest commented Dec 19, 2024

This fixes a runtime panic when generating links to fsck logs.

@a-nogikh
Copy link
Collaborator

a-nogikh commented Dec 19, 2024

We also need to add one handler like these:
https://github.com/google/syzkaller/blob/master/dashboard/app/main.go#L48

@FlorentRevest
dashboard/app: provide a text filename to fsck logs
d3c7ef5 
This fixes a runtime panic when generating links to fsck logs.
@FlorentRevest
Copy link
Collaborator Author

FlorentRevest commented Dec 19, 2024

We also need to add one handler like these:
https://github.com/google/syzkaller/blob/master/dashboard/app/main.go#L48

Thanks, done :)

@a-nogikh a-nogikh added this pull request to the merge queue Dec 19, 2024
Merged via the queue into google:master with commit 5905cb3 Dec 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-nogikh a-nogikh a-nogikh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FlorentRevest @a-nogikh