pkg/email/lore: extract patch series #5656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
reviewed
Jan 3, 2025
a-nogikh
force-pushed
the
features/lore-series
branch
from
7456137 to
000f165
Compare
tarasmadan
reviewed
Jan 9, 2025
tarasmadan
reviewed
Jan 9, 2025
tarasmadan
reviewed
Jan 9, 2025
tarasmadan
previously approved these changes
Jan 9, 2025
Collaborator
tarasmadan
left a comment
tarasmadan
left a comment
There was a problem hiding this comment.
LGTM. Please extend comments to speed-up the code understanding process.
Refactor the code to make it more reusable. Add a method to extract specifically the list of new patch series.
a-nogikh
force-pushed
the
features/lore-series
branch
from
000f165 to
5831188
Compare
tarasmadan
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of #5620.
Refactor the code to make it more reusable.
Add a method to extract specifically the list of new patch series.