-
Notifications
You must be signed in to change notification settings - Fork 1.4k
pkg/vcs: export GitWrapper #5657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Commit comment doesn't explain what's going on. |
|
Please start from the explanation why this git wrapper is needed. |
6cb29cf to
ded6c19
Compare
|
Updated the commit description to Re. the usages -- see Specifically, I could not use |
The current common vcs interface and its implementations are designed to support a very big number of situations (git modules, cleaning up complex state, etc), which is too heavy and restrictive when we just need a thin wrapper over the git command that supports a few basic operations. Refactor pkg/vcs to split out the wrapper code from the big git implementation of the vcs.Repo interface. Export the wrapper to enable reuse in other parts of the system.
ded6c19 to
444f40b
Compare
One more part of #5620 (see the discussion there as well).
It will let other parts of the code to use only the git-specific functionality.