vm: fix deadlock in UnusedTCPPort #5658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvyukov
previously approved these changes
Jan 7, 2025
Collaborator
dvyukov
left a comment
dvyukov
left a comment
There was a problem hiding this comment.
Looks good to me (but I think CI will bark on the error message capitalization).
Collaborator
|
As Dmitry noted, CI tests have failed on this PR. Please address the reported errors (the check should be also triggerable locally via |
p13l13d13
force-pushed
the
fix-unused-tcp-port-deadlock
branch
from
3e4c688 to
228d338
Compare
Collaborator
|
Please drop the |
If localhost is not configured on a system, UnusedTCPPort will loop forever without producing any errors. By checking EADDRINUSE and ENOACC and then skipping only in these cases, we'd avoid at least the mentioned deadlock. On top of this, this change should catch other errors without locking, like other DNS errors and so on. Signed-off-by: Ivan Gulakov <gulakov@amazon.de>
p13l13d13
force-pushed
the
fix-unused-tcp-port-deadlock
branch
from
c8ac1b1 to
89be30f
Compare
a-nogikh
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If localhost is not configured on a system, UnusedTCPPort will loop forever without producing any errors. By checking EADDRINUSE and ENOACC and then skipping only in these cases, we'd avoid at least the mentioned deadlock.
On top of this, this change should catch other errors without locking, like other DNS errors and so on.