Skip to content

Conversation

@tarasmadan
Copy link
Collaborator

@tarasmadan tarasmadan commented Feb 18, 2025

#5668 for the wider context

  • add tests
  • check the resulting report size

The exported jsonl lines len statistics
Average: 155514
Max: 1220378
Min: 556
25th percentile: 18392
50th percentile: 58633
75th percentile: 166546

200KB is the average json line.
Every jsonl line has the program and information about all the visited frames.

@tarasmadan tarasmadan changed the title Export programs pkg/manager: export programs with coverage Feb 18, 2025
@tarasmadan tarasmadan requested review from avagin and removed request for avagin February 18, 2025 14:43
@tarasmadan tarasmadan force-pushed the export_programs branch 2 times, most recently from b578484 to 811ce5d Compare February 21, 2025 10:37
@tarasmadan tarasmadan force-pushed the export_programs branch 10 times, most recently from 113390f to 4ec2452 Compare February 27, 2025 09:32
@tarasmadan tarasmadan marked this pull request as ready for review February 27, 2025 09:44
@tarasmadan tarasmadan requested a review from avagin as a code owner February 27, 2025 09:44
@tarasmadan tarasmadan requested review from a-nogikh and removed request for avagin February 27, 2025 09:44
The export is quite big but is generated fast.
Every line is a valid json object representing the single program coverage.
This function reached the cyclo complexity limit 24
@tarasmadan
Copy link
Collaborator Author

@a-nogikh ptal

@tarasmadan tarasmadan enabled auto-merge February 27, 2025 18:53
@tarasmadan tarasmadan added this pull request to the merge queue Feb 28, 2025
Merged via the queue into google:master with commit 67cf534 Feb 28, 2025
17 checks passed
@tarasmadan tarasmadan deleted the export_programs branch March 6, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants