pkg/symbolizer: introduce Symbolizer interface #5817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
force-pushed
the
symbolize-dwarf
branch
6 times, most recently
from
41b6ca9 to
d5eb4f6
Compare
tarasmadan
commented
Mar 6, 2025
tarasmadan
requested review from
a-nogikh
and removed request for
eepeep,
glpesk and
mvanotti
a-nogikh
reviewed
Mar 6, 2025
To simplify interface Read*Symbols were moved out from symbolizer.Symbolizer.
tarasmadan
force-pushed
the
symbolize-dwarf
branch
from
d5eb4f6 to
e3e3a66
Compare
a-nogikh
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring is needed to simplify the dwarf based symbolizer landing.