dashboard/app: fix histogram numbers #5875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago we added the per-manager statistics. Histogram was broken since that moment. Closes google#5867.
tarasmadan
force-pushed
the
fix-histogram
branch
from
f7da15f to
9e8f332
Compare
Collaborator
|
Is it possible to have a test that at least just queries all these pages and checks that it does not crash/fail as we do for other pages? |
Collaborator
Author
|
Crashing on request looks better than wrong numbers. It is the reason I'm submitting this one w/o tests. |
dvyukov
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago we added the per-manager statistics.
Histogram was broken since that moment.
Closes #5867.