syz-cluster: refactor blob storage #6018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split URI generation and write operation of the blob storage. This allows to do quick "if URI does not exist, generate and save it" operation within DB transactions and do the actual write at a later point. Since we don't use two-stage commits here, there's a risk of inconsistency between the blob storage and the DB, and we can only pick one that'd be more affected. In the current scheme: 1) For crash artifacts, we store artifacts before saving an entry to the DB, so we risk having garbage in the blob storage. 2) For logs/debugging info, we first update the DB and then write the logs. We risk not serving the latest logs from the dashboard. These choices can be changed any time.
tarasmadan
reviewed
May 16, 2025
tarasmadan
reviewed
May 16, 2025
| var stmts []*spanner.Mutation | ||
|
|
||
| _, iterErr := iter.Next() | ||
| if iterErr == nil { |
Collaborator
There was a problem hiding this comment.
Reordering this if->else if->else you can merge 2 beforeSave calls and shift left some code
Collaborator
There was a problem hiding this comment.
if iterErr != iterator.Done {
return iterErr
}
if beforeSave != nil {
err := beforeSave(test)
if err != nil {
return err
}
}
...
if iterErr == nil {
...
}
Collaborator
Author
|
Deprecated in favor of #6082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split URI generation and write operation of the blob storage.
This allows to do quick "if URI does not exist, generate and save it" operation within DB transactions and do the actual write at a later point.
Since we don't use two-stage commits here, there's a risk of inconsistency between the blob storage and the DB, and we can only pick one that'd be more affected.
In the current scheme:
DB, so we risk having garbage in the blob storage.
logs. We risk not serving the latest logs from the dashboard.
These choices can be changed any time.