syz-ci: use context for termination #6066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
force-pushed
the
syz-ci-uses-context
branch
4 times, most recently
from
6fef696 to
679e6c8
Compare
1. Use context for the goroutines termination. 2. uploadCoverJSONLToGCS reached 8 params, refactor.
tarasmadan
force-pushed
the
syz-ci-uses-context
branch
from
679e6c8 to
e32e893
Compare
dvyukov
approved these changes
Jun 4, 2025
a-nogikh
added a commit
to a-nogikh/syzkaller
that referenced
this pull request
Jun 10, 2025
After google#6066, we have started to see a number of log messages about bench/corpus uploads aborted due to context cancelation. These messages are not of any value. Ignore Errorf() calls where one of the arguments encloses a context.Canceled error. This is probably a bit hacky, but at least prevents repeating errors.Is(err, context.Canceled) for every call that may be canceled.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
After #6066, we have started to see a number of log messages about bench/corpus uploads aborted due to context cancelation. These messages are not of any value. Ignore Errorf() calls where one of the arguments encloses a context.Canceled error. This is probably a bit hacky, but at least prevents repeating errors.Is(err, context.Canceled) for every call that may be canceled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.