pkg: restore vcs.TreeLink and html.SetGlobSearchPath #6077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
previously approved these changes
Jun 6, 2025
Collaborator
tarasmadan
left a comment
tarasmadan
left a comment
There was a problem hiding this comment.
Please check whether we can restore only 10 lines.
melver
changed the title
tarasmadan
previously approved these changes
Jun 6, 2025
Collaborator
tarasmadan
left a comment
tarasmadan
left a comment
There was a problem hiding this comment.
Could you please also comment these functions to increase thein survival probability?
Collaborator
Author
Best would be to mark these as "used", but I don't know a way to do that. Any comments here may be ignored by another auto-dead-code-elimination attempt. I can add "Used externally - do not remove"? |
Collaborator
|
It is asking you to also rename the commit. |
tarasmadan
approved these changes
Jun 6, 2025
melver
changed the title
melver
changed the title
This partially reverts commit 43f51a0 to restore vcs.TreeLink and html.SetGlobSearchPath. This broke internal code.
melver
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 43f51a0 to restore vcs.TreeLink, and html.SetGlobSearchPath.
This broke internal code.