Skip to content

pkg/report: demangle Rust symbols #6087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a-nogikh merged 2 commits into from
Jun 18, 2025
Merged

pkg/report: demangle Rust symbols #6087

a-nogikh merged 2 commits into from
Jun 18, 2025

Conversation

@a-nogikh
Copy link
Collaborator

@a-nogikh a-nogikh commented Jun 12, 2025 •
edited
Loading

Closes #6035.

@a-nogikh a-nogikh changed the title pkg/report: demangle Rust symbols in the backtract pkg/report: demangle Rust symbols in the backtrace Jun 12, 2025
@a-nogikh a-nogikh force-pushed the features/demangle-rust-reports branch from 1d57e28 to e6d21cb Compare June 12, 2025 16:53
@a-nogikh a-nogikh changed the title pkg/report: demangle Rust symbols in the backtrace pkg/report: demangle Rust symbols Jun 12, 2025
@a-nogikh a-nogikh requested a review from tarasmadan June 17, 2025 07:54
@a-nogikh a-nogikh force-pushed the features/demangle-rust-reports branch from e6d21cb to 13f394e Compare June 17, 2025 08:11
@a-nogikh
Copy link
Collaborator Author

a-nogikh commented Jun 17, 2025

The PR has made TestParse slower: it now takes ~9 seconds to process 745 reports vs ~6 seconds it used to take on the current master, but that is likely not very significant:

  • As part of the test, we now also invoke Symbolize(), which we didn't do in the test, but always do when fuzzing.
  • The time to process a single report is very small anyway.

tarasmadan
tarasmadan reviewed Jun 17, 2025
View reviewed changes
tarasmadan
tarasmadan reviewed Jun 17, 2025
View reviewed changes
@a-nogikh
pkg/report: refactor Linux report symbolization
208da36 
Parse and assemble Linux backtrace lines independently of whether
vmlinux is present.

Refactor the code to make it easier to insert more postprocessing
actions.
@a-nogikh a-nogikh force-pushed the features/demangle-rust-reports branch from 13f394e to 40c761d Compare June 17, 2025 16:24
@a-nogikh
pkg/report: demangle Rust reports
bd223da 
Do demangling as a part of Symbolize() processing.
Add a TestSymbolize test to verify the results.
Fix old report_test.go bugs to better react to the -update flags.

Closes google#6035.
@a-nogikh a-nogikh force-pushed the features/demangle-rust-reports branch from 40c761d to bd223da Compare June 17, 2025 16:52
@a-nogikh a-nogikh requested a review from tarasmadan June 17, 2025 17:05
tarasmadan
tarasmadan approved these changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@tarasmadan tarasmadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@a-nogikh a-nogikh added this pull request to the merge queue Jun 18, 2025
Merged via the queue into google:master with commit ca631f7 Jun 18, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasmadan tarasmadan tarasmadan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pkg/report: demangle rust reports

2 participants

@a-nogikh @tarasmadan