-
Notifications
You must be signed in to change notification settings - Fork 1.4k
sys/linux: update descriptions in dev_block.txt #6088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Regarding null_blk.zoned=1 - if we set it on syzbot, we won't test the code that needs null_blk.zoned=0, right? Is it somehow possible to somehow test both?
If not, I guess we could set now I've noticed #6089 you openednull_blk.zoned=1 on some of our instances.
A few things done here:
- Add new block device ioctls (and structs) related to encryption,
added in 1ebd4a3c095c ("blk-crypto: add ioctls to create and
prepare hardware-wrapped keys"):
BLKCRYPTOIMPORTKEY
BLKCRYPTOGENERATEKEY
BLKCRYPTOPREPAREKEY
Deviate slightly from original keys-related structs to ensure that
ioctl syscalls have preallocated buffers to work with, not merely
pointers that go nowhere.
- Add and update new/missing syscalls related to zoned block devices:
BLKGETZONESZ
BLKGETNRZONES
BLKOPENZONE
BLKCLOSEZONE
BLKFINISHZONE
- Add a few other missing syscalls, such as BLKRASET.
- Fix some syscalls' directions (mostly, to 'inout').
71cbd28 to
1156dd5
Compare
|
v2:
We still need to figure out how to:
|
a-nogikh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Shall we merge the PR now? Or did you want to include something else to this change set?
Let's merge now, I'll figure out crypto ioctl issue separately, same goes for zoned null_blk. Thank you! |
A few things done here:
BLKCRYPTOIMPORTKEY
BLKCRYPTOGENERATEKEY
BLKCRYPTOPREPAREKEY
BLKGETZONESZ
BLKGETNRZONES
BLKOPENZONE
BLKCLOSEZONE
BLKFINISHZONE
Tested with
make presubmitand local syzkaller instance with 'null_blk.zoned=1'. No descriptions were deleted, only modified.P.S. To fully utilize zoned-related ioctls, we need to come up with a way to change /dev/nullb0 to zoned device and back.