Handle recent changes to Fuchsia's ffx tool #6112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpesk
force-pushed
the
syzkallnix
branch
2 times, most recently
from
85cc7cf to
634b89c
Compare
eepeep
reviewed
Jun 27, 2025
Collaborator
eepeep
left a comment
eepeep
left a comment
There was a problem hiding this comment.
Sorry to take a bit to get back to you on this! Generally seems good to me, assuming that this is the approach recommended by the ffx team, with a couple nits for readability. Thank you for fixing this!
glpesk
force-pushed
the
syzkallnix
branch
2 times, most recently
from
4d8d91e to
b06846c
Compare
ffx emu now needs to know the locations of some host tools. Copy these paths from the default ffx config into the configuration for the isolated ffx instance that syzkaller uses for most tasks.
ffx log is now built separately from the main ffx binary.
eepeep
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, some subcommands of
ffxhave been split into separate binaries, and others depend on prebuilt artifacts. This PR updates the Starnix VM startup script to get the current path for each artifact (either from the default ffx config or from the tool manifest), and refactors the ffx helpers to make the call sites more consistent.(Starnix bug ref: this is a fix for https://fxbug.dev/409390594.)