pkg/report: improve Rust report parsing #6115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to look for the error type after the "rust_kernel: panicked" line. Ignore some common irrelevant frames.
tarasmadan
approved these changes
Jun 20, 2025
tarasmadan
reviewed
Jun 20, 2025
| { | ||
| title: compile("rust_kernel: panicked"), | ||
| report: compile("rust_kernel: panicked at [^\n]*?\n(.+?)\n"), | ||
| fmt: "%[1]v in %[2]v", |
Collaborator
There was a problem hiding this comment.
It is hard to distinguish. All other titles have unique prefixes.
"rust_kernel panicked: %[1]v in %[2]v" for example.
I'll include this change in my PR to not forget.
Collaborator
Author
There was a problem hiding this comment.
I don't know if the unique rust_kernel panicked prefix will help a lot with setting the type - it's not a single "rust crash" type, there are many options, which are totally different:
null pointer dereference occurredattempt to subtract with overflow
It's not useful to combine these all into one category either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to look for the error type after the "rust_kernel: panicked" line.
Ignore some common irrelevant frames.