Skip to content

pkg/instance: fix sandbox_arg passing #6281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-nogikh merged 1 commit into from
Aug 20, 2025
Merged

pkg/instance: fix sandbox_arg passing #6281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/instance/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ func ExecprogCmd(execprog, executor, OS, arch, vmType string, opts csource.Optio
if optionalFlags {
optionalArg += " " + tool.OptionalFlags([]tool.Flag{
{Name: "slowdown", Value: fmt.Sprint(slowdown)},
{Name: "sandboxArg", Value: fmt.Sprint(opts.SandboxArg)},
{Name: "sandbox_arg", Value: fmt.Sprint(opts.SandboxArg)},
{Name: "type", Value: fmt.Sprint(vmType)},
})
}
Expand Down
4 changes: 4 additions & 0 deletions pkg/instance/instance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func TestExecprogCmd(t *testing.T) {
flagSignal := flags.Bool("cover", false, "collect feedback signals (coverage)")
flagSandbox := flags.String("sandbox", "none", "sandbox for fuzzing (none/setuid/namespace/android)")
flagSlowdown := flags.Int("slowdown", 1, "")
flagSandboxArg := flags.Int("sandbox_arg", 0, "argument for sandbox runner to adjust it via config")
cmdLine := ExecprogCmd(os.Args[0], "/myexecutor", targets.FreeBSD, targets.I386, "vmtype",
csource.Options{
Sandbox: "namespace",
Expand Down Expand Up @@ -81,6 +82,9 @@ func TestExecprogCmd(t *testing.T) {
if *flagSandbox != "namespace" {
t.Errorf("bad sandbox: %q, want: %q", *flagSandbox, "namespace")
}
if *flagSandboxArg != 3 {
t.Errorf("bad sandbox_arg: %q, want: %q", *flagSandboxArg, 3)
}
if *flagSignal {
t.Errorf("bad signal: %v, want: %v", *flagSignal, false)
}
Expand Down
Loading