Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/freebsd/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -227,4 +227,4 @@ If something does not work, try adding the `-debug` flag to `syz-manager`.
- We should provide instructions for fuzzing a FreeBSD system on ZFS
- `pkg/host` needs to be taught how to detect supported syscalls/devices.
- KASAN and KCSAN for FreeBSD would be useful.
- On Linux we have emission of exernal networking/USB traffic into kernel using tun/gadgetfs. Implementing these for FreeBSD could uncover a number of high-profile bugs.
- On Linux we have emission of external networking/USB traffic into kernel using tun/gadgetfs. Implementing these for FreeBSD could uncover a number of high-profile bugs.
2 changes: 1 addition & 1 deletion docs/freebsd/found_bugs.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Newer bugs come first
- [Fix an off-by-one error in the input validation of the SCTP_RESET_STREAMS socketoption.](https://reviews.freebsd.org/rS343769)
- [Limit the user-controllable amount of memory the kernel allocates via IPPROTO_SCTP level socket options.](https://reviews.freebsd.org/rS343089)
- [Fix getsockopt() for IP_OPTIONS/IP_RETOPTS.](https://reviews.freebsd.org/rS342879)
- [Avoid overfow in vtruncbuf().](https://reviews.freebsd.org/rS342857)
- [Avoid overflow in vtruncbuf().](https://reviews.freebsd.org/rS342857)
- [Limit option_len for the TCP_CCALGOOPT.](https://reviews.freebsd.org/rS341335)
- [Correct vm_fault_copy_entry() handling of backing file truncation after the file mapping was wired.](https://reviews.freebsd.org/rS338999)
- [In vm_fault_copy_entry(), we should not assert that entry is charged if the dst_object is not of swap type.](https://reviews.freebsd.org/rS338998)
Expand Down
2 changes: 1 addition & 1 deletion docs/internals.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ red labels indicate corresponding configuration options.
It runs on a host with a stable kernel which does not experience white-noise fuzzer load.

`syz-manager` starts `syz-executor` processes (one inside each VM).
`syz-executor`s comminucate with `syz-manager` over RPC to receive the programs
`syz-executor`s communicate with `syz-manager` over RPC to receive the programs
that must be executed and to report back the results (error statuses, collected coverage, etc.).

To execute programs, `syz-executor` starts transient subprocesses.
Expand Down
2 changes: 1 addition & 1 deletion docs/linux/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Make sure that your GCC meets this requirement, or get a GCC that [syzbot](/docs
### Linux Kernel

Besides coverage support in GCC, you also need support for it on the kernel side.
KCOV was added into mainline Linux kernel in version 4.6 and is be enabled by `CONFIG_KCOV=y` kernel configation option.
KCOV was added into mainline Linux kernel in version 4.6 and is be enabled by `CONFIG_KCOV=y` kernel configuration option.
For older kernels you need to at least backport commit [kernel: add kcov code coverage](https://github.com/torvalds/linux/commit/5c9a8750a6409c63a0f01d51a9024861022f6593).
Besides that, it's recommended to backport all kernel patches that touch `kernel/kcov.c`.

Expand Down
2 changes: 1 addition & 1 deletion docs/linux/setup_linux-host_qemu-vm_arm64-kernel.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Choose the following options.

Run `make`. After the build, confirm that `output/images/rootfs.ext3` exists.

If you're expreriencing a very slow sshd start up time with arm64 qemu running on x86, the reason is probably low entropy and it be "fixed" with installing `haveged`. It can be found in the buildroot `menuconfig`:
If you're experiencing a very slow sshd start up time with arm64 qemu running on x86, the reason is probably low entropy and it be "fixed" with installing `haveged`. It can be found in the buildroot `menuconfig`:

```
Target packages
Expand Down
2 changes: 1 addition & 1 deletion docs/linux/setup_linux-host_qemu-vm_riscv64-kernel.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- -j $(nproc)

# OpenSBI

Clone the OpenSBI repository and build the bootable OpenSBI image containg the kernel:
Clone the OpenSBI repository and build the bootable OpenSBI image containing the kernel:

```shell
git clone https://github.com/riscv/opensbi
Expand Down
10 changes: 5 additions & 5 deletions docs/maintaining.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Pull requests (PR) have only 2 options:
`cla/google` check needs to pass before merging.

CI testing generally needs to pass before merging.\
Exceptions may be infrastrcture flakes (especially in external services: `codecov`, `ci/fuzzit`);
Exceptions may be infrastructure flakes (especially in external services: `codecov`, `ci/fuzzit`);
one-off timeouts/OOMs (but not if this PR itself makes them much more frequent).
All static checking warnings and testing errors are considered hard errors.

Expand All @@ -28,12 +28,12 @@ Adding tests for new code and bug fixes is generally encouraged. Ask contributor

However, some code is easier to test, while some is harder. Some examples of cases where
it's easier to add tests (should be added): abstract functionalities without external dependencies
(e.g. parsers, data transformations, calculations); code with established testing infrastrcture
(e.g. parsers, data transformations, calculations); code with established testing infrastructure
(adding new tests is just adding one more of the same). Examples of cases where it's harder
to add tests (may be not added, but still welcome if one wants to go above and beyond):
code with external dependancies that are not easy to fake out (qemu, kernel, image, etc);
code without established testing infrastrcture where adding one test would require building
the whole infrastrcture first.
code with external dependencies that are not easy to fake out (qemu, kernel, image, etc);
code without established testing infrastructure where adding one test would require building
the whole infrastructure first.

## Use your judgement

Expand Down
2 changes: 1 addition & 1 deletion docs/openbsd/found_bugs.md
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ Newer bugs comes first.

- [ioctl: reject inappropriate commands in `wsmux_do_ioctl()`](https://marc.info/?l=openbsd-cvs&m=154507410803526&w=2)

- [getsockopt: errorneous switch fall through in `rip_usrreq()` affecting many socket related syscalls](https://marc.info/?l=openbsd-cvs&m=154383186000797&w=2)
- [getsockopt: erroneous switch fall through in `rip_usrreq()` affecting many socket related syscalls](https://marc.info/?l=openbsd-cvs&m=154383186000797&w=2)

- [shutdown: integer overflow in `unp_internalize()`](https://marc.info/?l=openbsd-cvs&m=154282004307882&w=2) [ERRATA-64-006](https://ftp.openbsd.org/pub/OpenBSD/patches/6.4/common/006_uipc.patch.sig)

Expand Down
2 changes: 1 addition & 1 deletion docs/openbsd/gce.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ci-openbsd host

OpenBSD continous integration build machine has two disks. The root image is
OpenBSD continuous integration build machine has two disks. The root image is
generated by `tools/create-openbsd-gce-ci.sh`. This disk is disposable and will
be rebuilt when compatibility bumps in OpenBSD-current are encountered. Manual
tweaks to this image without updating the script will be lost.
Expand Down
2 changes: 1 addition & 1 deletion docs/syscall_descriptions_syntax.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ foo {
Structs can have attributes specified in square brackets after the struct.
Attributes are:

- `packed`: the struct does not have paddings between fields and has alignment 1; this is similar to GNU C `__attribute__((packed))`; struct alignment can be overriden with `align` attribute
- `packed`: the struct does not have paddings between fields and has alignment 1; this is similar to GNU C `__attribute__((packed))`; struct alignment can be overridden with `align` attribute
- `align[N]`: the struct has alignment N and padded up to multiple of `N`; contents of the padding are unspecified (though, frequently are zeros); similar to GNU C `__attribute__((aligned(N)))`
- `size[N]`: the struct is padded up to the specified size `N`; contents of the padding are unspecified (though, frequently are zeros)

Expand Down
Loading