pkg/report: get only the thread local reports #6376
Conversation
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
from
d565a9a to
1e097c2
Compare
ramosian-glider
left a comment
ramosian-glider
left a comment
There was a problem hiding this comment.
I think this code should also handle reports from the CPU context.
|
Please extend the commit/PR description, I have only read what you provided here (I have no other context) and thus I struggle to understand the problem it's supposed to solve. |
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
8 times, most recently
from
003ba11 to
712a9bf
Compare
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
2 times, most recently
from
c3fce1f to
5df187e
Compare
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
from
5df187e to
3b478c9
Compare
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
2 times, most recently
from
11e39ad to
d7e78a4
Compare
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
5 times, most recently
from
a4381d4 to
6d9f46d
Compare
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
4 times, most recently
from
9d4acf4 to
f087984
Compare
tarasmadan
requested review from
a-nogikh and
dvyukov
and removed request for
avagin
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
from
f087984 to
b3205a4
Compare
dvyukov
left a comment
dvyukov
left a comment
There was a problem hiding this comment.
Please check other test changes for sanity.
| path_openat+0x3603/0x64c0 | ||
| ===================================================== | ||
| TAIL REPORTS: | ||
| prepare_task_switch+0x284/0xd00 |
There was a problem hiding this comment.
Title line is "Kernel panic - not syncing: panic_on_kmsan set ..."
Because it is a report with Thread IDs, we save up to 50 prefix lines.
The parsing was started after the "BUG: KMSAN: uninit-value in prepare_task_switch+0x284/0xd00" thus all the lines (~18) were included.
We can alternatively remove all the prefix lines for the tail reports.
| Kernel Offset: disabled | ||
| Rebooting in 86400 seconds.. | ||
| TAIL REPORTS: | ||
| Kernel panic - not syncing: panic_on_warn set ... |
There was a problem hiding this comment.
This may be annoying. We have panic_on_warn report in most bugs. I think we need to exclude them.
There was a problem hiding this comment.
We plan to disable panic_on_warn eventually. To "do nothing" will also work.
The alternatives are:
- Do nothing.
- If the very next report line is another title - skip it.
- Ignore "panic_on_warn" reports.
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
2 times, most recently
from
e699e8a to
239445b
Compare
Syzkaller is currently able to parse sequential reports from the kernel log and accumulate the statistics per report. You can see these reports in syzkaller only (not syzbot dashboard). The problems: 1. These reports may be interleaving if are coming from the parallel contexts (threads) 2. Getting reports from one thread instead of all threads will hopefully give a higher signal/noise ratio. This PR improves sequential reports parsing and is not expected to affect "first report" extraction.
And regenerate test with tail reports and ContextIDs.
tarasmadan
force-pushed
the
get-only-the-thread-reports
branch
from
239445b to
a0c4fe5
Compare
4 participants
Syzkaller is currently able to parse sequential reports from the kernel log and accumulate the statistics per report. You can see these reports in syzkaller only (not syzbot dashboard).
The problems:
This PR improves sequential reports parsing and is not expected to affect "first report" extraction.
Eventually the plan is to disable panic_on_warn and start getting sequential reports.
TODO: