vm: react to context cancellation and better handle errors in VM creation #6377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Added two |
tarasmadan
reviewed
Sep 29, 2025
Enable external abortion of the instance creation process. This is especially useful for the qemu case where we retry the creation/boot up to 1000 times, which can take significant time (e.g. it timeouts syz-cluster pods on unstable kernels). The context can be further propagated to WaitForSSH, but that requires another quite significant vm/ refactoring.
In almost all cases these mean some boot time crash. It also doesn't make much sense to continue string matching since the boot output may contain the matched strings in benign contexts.
After this change it fits more naturally into the Go's error functionality.
This is a much cleaner logic than string matching.
a-nogikh
force-pushed
the
features/vm-qemu-context
branch
from
d85ea03 to
0ff7b35
Compare
Collaborator
Author
|
Fixed the failing test. |
tarasmadan
approved these changes
Oct 1, 2025
Collaborator
tarasmadan
left a comment
tarasmadan
left a comment
There was a problem hiding this comment.
It also doesn't make much sense to continue string matching since the boot output may contain the matched strings in benign contexts.
I didn't understand this part. Could you please explain the details here?
Collaborator
Author
|
The original problem was that, for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable external abortion of the instance creation process. This is
especially useful for the qemu case where we retry the creation/boot up
to 1000 times, which can take significant time (e.g. it timeouts
syz-cluster pods on unstable kernels).
The context can be further propagated to WaitForSSH, but that requires
another quite significant vm/ refactoring.
In almost all cases these mean some boot time crash.
It also doesn't make much sense to continue string matching since the
boot output may contain the matched strings in benign contexts.
This sequence also asks for another change - we abuse
osutil.VerboseErrorin too many different contexts and in a way that contradicts current Go error wrapping APIs. In this particular case it prevents an adequate ssh timeout error detection (which should have been something likeerrors.Is(err, vmimpl.ErrSSHTimeout)). I'll see how tricky it will be to replaceVerboseErrorsTitleby some nestedError.