Skip to content

Conversation

@tarasmadan
Copy link
Collaborator

@tarasmadan tarasmadan commented Sep 30, 2025

First used in:

config CFI_CLANG
        bool
        transitional
        help
          Transitional config for CFI_CLANG to CFI migration.

https://lwn.net/Articles/1039256/
I needed it for linux-next experiments. For the current upstream we don't need it.

P.S.
https://www.phoronix.com/news/Linux-6.18-Transitional explains the keyword usage.

@tarasmadan tarasmadan marked this pull request as ready for review September 30, 2025 08:50
@a-nogikh
Copy link
Collaborator

Please add it to https://github.com/google/syzkaller/blob/master/pkg/kconfig/kconfig_test.go

Overall, in pkg/kconfig we do try to replicate the Kconfig logic. So, ideally, we should not just parse, but also process the flag - that is, it should not be in the output of

func ParseData(target *targets.Target, data []byte, file string) (*KConfig, error) {

If we ignore it, it will likely make config bisection (that we do at the beginning of a normal bisection) a tiny bit less efficient, so maybe in the end it's not worth it indeed. Still, would be nice to see a comment that we didn't actually process it intentionally.

See https://www.phoronix.com/news/Linux-6.18-Transitional .

First used in:
config CFI_CLANG
        bool
        transitional
        help
          Transitional config for CFI_CLANG to CFI migration.
@tarasmadan tarasmadan force-pushed the support-transitional branch from faafb53 to dc19cb0 Compare October 1, 2025 08:03
@tarasmadan
Copy link
Collaborator Author

PTAL. Added the test and comment.

@tarasmadan
Copy link
Collaborator Author

Thank you @a-nogikh for the approval.
CCed others just FYI.

@tarasmadan tarasmadan added this pull request to the merge queue Oct 1, 2025
Merged via the queue into google:master with commit 3af3964 Oct 1, 2025
17 checks passed
Copy link
Collaborator

@melver melver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, but probably no need to fix given this is already committed.

@tarasmadan tarasmadan deleted the support-transitional branch October 16, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants