Fix csource_test.go #6422
Merged
Fix csource_test.go #6422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a compilation error spotted by csource_test.go
struct kvm_ppc_mmuv3_cfg seems to be defined in /usr/powerpc64le-linux-gnu/include/asm/kvm.h, remove the duplicate definition.
Add #if checks to define executor_fn_guest_addr() for __NR_syz_kvm_setup_cpu and __NR_syz_kvm_setup_syzos_vm. This fixes a compilation error spotted by csource_test.go
Previously in the -short configuration testPseudoSyscalls() was only executed for the first supported target, which in most cases ended up being linux/386 (the least popular configuration). As a result, platform-specific pseudo-syscalls were never executed on the CI. Fix this by testing the pseudo-syscalls on all available platforms. This increases the execution time of TestGenerate from 18s to 36s, but also helps to discover bugs in pseudo-syscalls quicker. As a result of this change, 3 distinct latent bugs were found on amd64, arm64 and ppc64.
ramosian-glider
force-pushed
the
fix-452845181
branch
from
46313e6 to
27ef4be
Compare
a-nogikh
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md